Add GUARDRAIL span kind to arize tracing #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

CalebCourier merged 25 commits into guardrails-ai:main from abhishek9sharma:main

Feb 13, 2025

Contributor

abhishek9sharma commented Jan 25, 2025

Add GUARDRAIL span kind to arize tracing so that kind reflects on arize frontend

abhishek9sharma and others added 2 commits

January 25, 2025 21:11


          - Add OpenInference span kind attribute to Guardrails telemetry spans.

2e91405

- Updated version to 0.6.3 in pyproject.toml.


          Merge pull request #5 from abhishek9sharma/feat/add_span_type

42073fa

- Add OpenInference span kind attribute to Guardrails telemetry spans.

abhishek9sharma mentioned this pull request

Implemented redaction functions to obscure sensitive information in strings #1217

Merged

CalebCourier assigned CalebCourier and dtam

Contributor Author

abhishek9sharma commented Feb 6, 2025

Let me knnow if I need to change/fix something here

Contributor Author

abhishek9sharma commented Feb 10, 2025

@CalebCourier @dtam any feedback on this

Collaborator

CalebCourier commented Feb 12, 2025

Sorry @abhishek9sharma, we got caught up in some other projects. We'll take a look this week. Thanks for your patience!

CalebCourier reviewed

View reviewed changes

guardrails/telemetry/runner_tracing.py Outdated Show resolved Hide resolved

CalebCourier reviewed

View reviewed changes

guardrails/telemetry/runner_tracing.py Outdated Show resolved Hide resolved

CalebCourier reviewed

View reviewed changes

guardrails/telemetry/runner_tracing.py Outdated Show resolved Hide resolved

Collaborator

CalebCourier commented Feb 13, 2025

@abhishek9sharma I left a couple comments around treating openinference packages as optional dependencies. I'm going to go ahead and apply these changes so this PR can be included in today's release.

CalebCourier reviewed

View reviewed changes

guardrails/telemetry/guard_tracing.py Outdated Show resolved Hide resolved

CalebCourier reviewed

View reviewed changes

guardrails/telemetry/guard_tracing.py Outdated Show resolved Hide resolved

CalebCourier reviewed

View reviewed changes

guardrails/telemetry/guard_tracing.py Outdated Show resolved Hide resolved

CalebCourier reviewed

View reviewed changes

guardrails/telemetry/guard_tracing.py Outdated Show resolved Hide resolved

CalebCourier reviewed

View reviewed changes

guardrails/telemetry/guard_tracing.py Outdated Show resolved Hide resolved

CalebCourier reviewed

View reviewed changes

guardrails/telemetry/open_inference.py Outdated Show resolved Hide resolved

CalebCourier reviewed

View reviewed changes

guardrails/telemetry/runner_tracing.py Outdated Show resolved Hide resolved

CalebCourier reviewed

View reviewed changes

guardrails/telemetry/runner_tracing.py Outdated Show resolved Hide resolved

CalebCourier reviewed

View reviewed changes

guardrails/telemetry/runner_tracing.py Outdated Show resolved Hide resolved

CalebCourier reviewed

View reviewed changes

guardrails/telemetry/runner_tracing.py Outdated Show resolved Hide resolved

CalebCourier reviewed

View reviewed changes

guardrails/telemetry/validator_tracing.py Outdated Show resolved Hide resolved

CalebCourier reviewed

View reviewed changes

guardrails/telemetry/validator_tracing.py Outdated Show resolved Hide resolved

CalebCourier reviewed

View reviewed changes

guardrails/telemetry/open_inference.py Outdated Show resolved Hide resolved

CalebCourier reviewed

View reviewed changes

guardrails/telemetry/validator_tracing.py Outdated Show resolved Hide resolved

CalebCourier added 4 commits

February 13, 2025 09:30


          Make openinference an optional dependency

d975a5c


          Make openinference an optional dependency

d5086c9


          Make openinference an optional dependency

49fd872


          Make openinference an optional dependency

2e367af

CalebCourier added 12 commits

February 13, 2025 09:32


          Make openinference an optional dependency

8dcf880


          Make openinference an optional dependency

09070d9


          Make openinference an optional dependency

527ef42


          Make openinference an optional dependency

cedbf21


          remove duplicate import

32e7183


          Make openinference an optional dependency

97f3abc


          Make openinference an optional dependency

f86be8f


          Make openinference an optional dependency

db99101


          Make openinference an optional dependency

efa9d13


          Make openinference an optional dependency

2d98002


          Make openinference an optional dependency


          Make openinference an optional dependency

824d584

CalebCourier reviewed

View reviewed changes

guardrails/telemetry/open_inference.py Show resolved Hide resolved


          Formatting

b8fd754

CalebCourier reviewed

View reviewed changes

guardrails/telemetry/runner_tracing.py Show resolved Hide resolved


          Formatting

e8e4928

CalebCourier reviewed

View reviewed changes

guardrails/telemetry/validator_tracing.py Show resolved Hide resolved


          formatting

e8077ed

CalebCourier reviewed

View reviewed changes

guardrails/telemetry/guard_tracing.py Outdated Show resolved Hide resolved


          type ignore optional dep

fa0e234

CalebCourier reviewed

View reviewed changes

guardrails/telemetry/open_inference.py Outdated Show resolved Hide resolved


          type ignore optional dep

d25ecd7

CalebCourier reviewed

View reviewed changes

guardrails/telemetry/runner_tracing.py Outdated Show resolved Hide resolved


          type ignore optional dep

1ca9ef7

CalebCourier reviewed

View reviewed changes

guardrails/telemetry/validator_tracing.py Outdated Show resolved Hide resolved


          type ignore optional dep

9ab4123

Collaborator

CalebCourier commented Feb 13, 2025

Tests pass locally. They're failing here because of permissions issues since this is a fork.

CalebCourier approved these changes

View reviewed changes

Collaborator

CalebCourier left a comment •

edited

Loading

@abhishek9sharma I'm going to squash and merge this onto main to cleanup the commit history. Be sure to reset the HEAD of your fork to upstream/main afterwards.

CalebCourier merged commit 51b4bc6 into guardrails-ai:main

8 of 12 checks passed

Contributor Author

abhishek9sharma commented Feb 15, 2025

@abhishek9sharma I left a couple comments around treating openinference packages as optional dependencies. I'm going to go ahead and apply these changes so this PR can be included in today's release.

Thanks @CalebCourier for this feedback and fixes. Apprectiate the merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet